Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put missions on queue if ISAR already has a mission running #1879

Closed
andchiind opened this issue Dec 12, 2024 · 0 comments · Fixed by #1889
Closed

Put missions on queue if ISAR already has a mission running #1879

andchiind opened this issue Dec 12, 2024 · 0 comments · Fixed by #1889
Labels
backend Backend related functionality good first issue Good for newcomers improvement Improvement to existing functionality Northern Lights

Comments

@andchiind
Copy link
Contributor

andchiind commented Dec 12, 2024

Describe the improvement you would like to see
If we try to start a mission on ISAR and we get a 400 status code saying ISAR already has a mission, this could be caused by another Flotilla pod or thread already having started a mission. Currently we simply fail the mission we tried to schedule, but instead we should first verify whether the mission ISAR is already running is the one we tried to schedule (this would mean another thread already did the thing we wanted to do), in which case we ignore it, and if the mission in ISAR is different from the one we want to run, we should simply put the mission back on the queue.

This will require some minor changes in ISAR, since it currently doesn't report the current mission it is running if we try to run a mission when it is not in idle.

How will this change existing functionality?
It will improve concurrency between different Flotilla threads/instances. In the future, if we want to move the mission queue to ISAR instead of storing it in the Flotilla SQL database, then this would no longer be needed (equinor/isar#674).

How will this improvement affect the current Threat Model?
N/A

@andchiind andchiind added backend Backend related functionality good first issue Good for newcomers improvement Improvement to existing functionality Northern Lights labels Dec 12, 2024
@andchiind andchiind linked a pull request Dec 17, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality good first issue Good for newcomers improvement Improvement to existing functionality Northern Lights
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant