Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pressure display in mission page depending on pressure status #693

Closed
Eddasol opened this issue Mar 21, 2023 · 8 comments
Closed
Assignees
Labels
feature New feature or request frontend Frontend related functionality ux Issue needs input from UX designer

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Mar 21, 2023

Describe the new feature you would like to see
Consider changing how pressure is displayed in the mission page such that it depends on pressure status.

Outstanding part of #674

A value in mBar doesn't provide a lot of info without the limits as context. One possibility is displaying pressure status and pressure level i.e. "Good (67mBar)" and "Low (32mBar)" or using symbols

The design should be verified with @mariannewiggen

Describe the solution you'd like

How will this feature affect the current Threat Model?

@Eddasol Eddasol added feature New feature or request frontend Frontend related functionality ux Issue needs input from UX designer labels Mar 21, 2023
@aeshub
Copy link
Contributor

aeshub commented Jun 19, 2023

The limits may already be implemented in the backend database so these may be used directly when deciding what to display.

@UsamaEquinorAFK UsamaEquinorAFK self-assigned this Jul 5, 2023
@UsamaEquinorAFK
Copy link
Contributor

Implemented in #886

@aeshub
Copy link
Contributor

aeshub commented Sep 11, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Sep 11, 2023
@anetteu
Copy link
Member

anetteu commented Sep 22, 2023

Why is this issue archived but not closed? This is not implemented? Should be open and on the board, or closed if remaining parts of the issue are covered in other issues. Unarchiving issue and adding back to board for evaluation during planning.

@aeshub aeshub removed the stale This issue or pull request already exists label Sep 22, 2023
@UsamaEquinorAFK
Copy link
Contributor

This is implemented now. I remember going on vacation just after doing this. I can close it now or wait for @Eddasol to reply ? :)

@anetteu
Copy link
Member

anetteu commented Sep 22, 2023

I cannot see that this is implemented? What are the threshold values? As far as i can see, it is at least the same display from 18-78 mBar.

@anetteu
Copy link
Member

anetteu commented Sep 22, 2023

How it currently looks in prod:

Image

@UsamaEquinorAFK
Copy link
Contributor

I am writing a new issue for this bug @anetteu since this wont be a feature request but a bug report now. I will tag you there for your feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request frontend Frontend related functionality ux Issue needs input from UX designer
Projects
None yet
Development

No branches or pull requests

4 participants