-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should use plantCode when fetching echo missions #876
Comments
The necessary changes on our end have been implemented in #926 but the changes are not in Echo at the moment. The PR is shown as ready since the changes needed to fulfil this PR improves the code by making us store both the installation and plant code in the frontend, so it would be good to have in main. Only two lines need to be changed to make it request using PlantCode instead of InstallationCode (line 67 in MissionQueueView.tsx and line 36/37 in EchoService.cs) |
This issue has automatically been marked as stale as there has been no activity for 60 days. |
This issue has automatically been marked as stale as there has been no activity for 60 days. |
It is possible to amend the UI to make it display Installations instead of all the Plants |
This issue has automatically been marked as stale as there has been no activity for 60 days. |
This issue has automatically been marked as stale as there has been no activity for 60 days. |
Using installation code when fetching missions from echo gives a lot more missions than the once that are relevant. Will e.g. get missons from both Haugsneset and Johan Sverdrup when choosing either one of them. Same with Kårstø and Kalstø. See /api/plantInfo in https://echohubapi.equinor.com/.
Suggest getting echo to change parameter in endpoint "/api/robots/robot-plan" from installation code to plant code and implementing the same change on our side
The text was updated successfully, but these errors were encountered: