Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use plantCode when fetching echo missions #876

Open
Eddasol opened this issue Jul 3, 2023 · 6 comments
Open

Should use plantCode when fetching echo missions #876

Eddasol opened this issue Jul 3, 2023 · 6 comments
Labels
stale This issue or pull request already exists

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Jul 3, 2023

Using installation code when fetching missions from echo gives a lot more missions than the once that are relevant. Will e.g. get missons from both Haugsneset and Johan Sverdrup when choosing either one of them. Same with Kårstø and Kalstø. See /api/plantInfo in https://echohubapi.equinor.com/.

Suggest getting echo to change parameter in endpoint "/api/robots/robot-plan" from installation code to plant code and implementing the same change on our side

@andchiind
Copy link
Contributor

andchiind commented Aug 1, 2023

The necessary changes on our end have been implemented in #926 but the changes are not in Echo at the moment. The PR is shown as ready since the changes needed to fulfil this PR improves the code by making us store both the installation and plant code in the frontend, so it would be good to have in main. Only two lines need to be changed to make it request using PlantCode instead of InstallationCode (line 67 in MissionQueueView.tsx and line 36/37 in EchoService.cs)

@aeshub
Copy link
Contributor

aeshub commented Oct 1, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Oct 1, 2023
@oysand oysand removed the stale This issue or pull request already exists label Oct 2, 2023
@andchiind andchiind removed their assignment Oct 13, 2023
@aeshub
Copy link
Contributor

aeshub commented Dec 3, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Dec 3, 2023
@aeshub aeshub removed the stale This issue or pull request already exists label Dec 18, 2023
@tsundvoll
Copy link
Contributor

It is possible to amend the UI to make it display Installations instead of all the Plants

@aeshub
Copy link
Contributor

aeshub commented Jun 29, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jun 29, 2024
@Christdej Christdej removed the stale This issue or pull request already exists label Aug 5, 2024
@aeshub
Copy link
Contributor

aeshub commented Oct 10, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants