Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make battery and pressure status grey when robot is offline #912

Closed
anetteu opened this issue Jul 25, 2023 · 7 comments · Fixed by #930
Closed

Make battery and pressure status grey when robot is offline #912

anetteu opened this issue Jul 25, 2023 · 7 comments · Fixed by #930
Assignees
@UsamaEquinorAFK
Labels
frontend Frontend related functionality improvement Improvement to existing functionality ux Issue needs input from UX designer

Comments

@anetteu
Copy link
Member

anetteu commented Jul 25, 2023

Describe the improvement you would like to see
A suggestion to make it visible that the values are not live.

How will this change existing functionality?
A clear and concise description on how this will affect current functionality.

How will this improvement affect the current Threat Model?
Leave blank for maintainers to fill out if you are uncertain about this.
@anetteu anetteu added improvement Improvement to existing functionality frontend Frontend related functionality labels Jul 25, 2023
@anetteu anetteu changed the title Make battery and pressure status status grey when robot is offline Make battery and pressure status grey when robot is offline Jul 29, 2023
@UsamaEquinorAFK UsamaEquinorAFK self-assigned this Jul 31, 2023
@UsamaEquinorAFK UsamaEquinorAFK added the ux Issue needs input from UX designer label Jul 31, 2023
@UsamaEquinorAFK
Copy link
Contributor

UsamaEquinorAFK commented Jul 31, 2023 •
edited
Loading

Is it compliant with the design we have in Figma ?

@UsamaEquinorAFK
Copy link
Contributor

@mariannewiggen

@mariannewiggen
Copy link

mariannewiggen commented Jul 31, 2023 •
edited
Loading

I think it makes sense to do this if the status of the robot is offline. If the status of the robot is not offline, then I don't think it is clear enough that battery and pressure change color due to values not being live.

Link to suggestion for grey battery and pressure status in Figma: https://www.figma.com/file/q6vsNRogzV6r9vTCCDsocd/Robot-Missions?type=design&node-id=4642%3A732856&mode=dev

Image

@mariannewiggen
Copy link

mariannewiggen commented Jul 31, 2023 •
edited
Loading

Another suggestion could be to not show the value of battery and pressure if there is a high probability that the values will be wrong

Image

@UsamaEquinorAFK
Copy link
Contributor

I prefer the second option. Thanks :)

@UsamaEquinorAFK
Copy link
Contributor

#930

@UsamaEquinorAFK
Copy link
Contributor

UsamaEquinorAFK commented Aug 3, 2023 •
edited
Loading

@mariannewiggen is it okay to have the robot page after clicking on the selected robot as this when robot is offline ?
Image

Discussed further in #932

@UsamaEquinorAFK UsamaEquinorAFK linked a pull request Aug 3, 2023 that will close this issue
Update pressure and battery view if robot is offline #930
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UsamaEquinorAFK UsamaEquinorAFK

Labels
frontend Frontend related functionality improvement Improvement to existing functionality ux Issue needs input from UX designer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pressure and battery view if robot is offline UsamaEquinorAFK/flotilla
3 participants
@anetteu @UsamaEquinorAFK @mariannewiggen