From 01367115143c9b7c9636a40a4c6ab417a939ad73 Mon Sep 17 00:00:00 2001 From: andchiind Date: Wed, 18 Dec 2024 10:22:47 +0100 Subject: [PATCH 1/2] Remove unnecessary readonly false --- backend/api/EventHandlers/MqttEventHandler.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/api/EventHandlers/MqttEventHandler.cs b/backend/api/EventHandlers/MqttEventHandler.cs index 835856ded..8acd999cd 100644 --- a/backend/api/EventHandlers/MqttEventHandler.cs +++ b/backend/api/EventHandlers/MqttEventHandler.cs @@ -183,7 +183,7 @@ private async void OnIsarRobotInfo(object? sender, MqttReceivedArgs mqttArgs) try { - var robot = await RobotService.ReadByIsarId(isarRobotInfo.IsarId, readOnly: false); + var robot = await RobotService.ReadByIsarId(isarRobotInfo.IsarId, readOnly: true); if (robot == null) { From 81222d922fadbf6c2c7a1ce45bbc92230d42f6e2 Mon Sep 17 00:00:00 2001 From: andchiind Date: Wed, 18 Dec 2024 10:24:10 +0100 Subject: [PATCH 2/2] Remove old logging in mqtt event handler --- backend/api/EventHandlers/MqttEventHandler.cs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/backend/api/EventHandlers/MqttEventHandler.cs b/backend/api/EventHandlers/MqttEventHandler.cs index 8acd999cd..a39118155 100644 --- a/backend/api/EventHandlers/MqttEventHandler.cs +++ b/backend/api/EventHandlers/MqttEventHandler.cs @@ -89,13 +89,7 @@ private async void OnIsarStatus(object? sender, MqttReceivedArgs mqttArgs) if (robot.Status == isarStatus.Status) { return; } - var preUpdatedRobot = await RobotService.ReadByIsarId(isarStatus.IsarId, readOnly: true); - if (preUpdatedRobot == null) - { - _logger.LogInformation("Received message from unknown ISAR instance {Id} with robot name {Name}", isarStatus.IsarId, isarStatus.RobotName); - return; - } - _logger.LogInformation("OnIsarStatus: Robot {robotName} has status {robotStatus} and current inspection area {areaName}", preUpdatedRobot.Name, preUpdatedRobot.Status, preUpdatedRobot.CurrentInspectionArea?.Name); + _logger.LogInformation("OnIsarStatus: Robot {robotName} has status {robotStatus} and current inspection area {areaName}", robot.Name, robot.Status, robot.CurrentInspectionArea?.Name); _updateRobotSemaphore.WaitOne(); _logger.LogDebug("Semaphore acquired for updating robot status");