Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stop button #140

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement stop button #140

wants to merge 1 commit into from

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Mar 1, 2024 •
edited
Loading

Closes #121

@andchiind andchiind marked this pull request as draft March 1, 2024 10:40
Christdej
Christdej reviewed Mar 5, 2024
View reviewed changes
src/isar_exr/robotinterface.py
)
max_request_attempts: int = 10
stop_mission_attempts: int = 0
while stop_mission_attempts < max_request_attempts:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment on why we need to try stopping so many times?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll test soon without these retries and see how reliable it is now that we have more error handling. We might not need the retries.

@andchiind andchiind mentioned this pull request Mar 7, 2024
Open
@aeshub
Copy link
Contributor

aeshub commented May 2, 2024

This pull request has automatically been marked as stale as there has been no activity for 30 days. Remove stale label or comment or this will be closed in 7 days.

@aeshub aeshub added the stale label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop mission isn't working
3 participants
@andchiind @aeshub @Christdej