Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mission_complete state to state machine #657

Open
Eddasol opened this issue Dec 2, 2024 · 1 comment
Open

Add mission_complete state to state machine #657

Eddasol opened this issue Dec 2, 2024 · 1 comment
Labels
improvement Improvement to existing functionality

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Dec 2, 2024

Describe the improvement you would like to see
Currently a lot of cleanup from previous missions are performed in initialize of the next mission. Suggest creating a mission_complete state after completion of missions, that has responsibility for cleaning up before returning to idle.

This state would be quite similar to initialize but with focus on cleanup after missions instead of preparation at the beginning of a mission.

How will this change existing functionality?
More intuitive behavior of functions. Increased readability

How will this improvement affect the current Threat Model?

@Eddasol Eddasol added the improvement Improvement to existing functionality label Dec 2, 2024
@tsundvoll
Copy link
Contributor

tsundvoll commented Dec 2, 2024

This mission_complete sounds more like an event; therefore it should not be a state.

The requested functionality (cleanup from previous mission) can happen in the transition, rather in any state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants