Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Unlocalised state #665

Open
andchiind opened this issue Dec 6, 2024 · 2 comments
Open

Introduce Unlocalised state #665

andchiind opened this issue Dec 6, 2024 · 2 comments
Labels
breaking-change A breaking change which introduces changes to the public APIs feature New feature or request Northern Lights

Comments

@andchiind
Copy link
Contributor

Describe the new feature you would like to see
The name of the state is not important, but we need to state that informs listeners on MQTT that the robot is not ready to run missions since it is no longer localised. It should not be able to leave this state until localisation is regained, which can either happen internally in the ISAR state, or via a new localisation endpoint if it is not able to handle it automatically.

Describe the solution you'd like
Based on how the robot responds when running a mission, ISAR implementations should be able to give feedback to the statemachine that it should move to a delocalised state, and this should then be reported as a robot state in the MQTT status publisher.

How will this feature affect the current Threat Model?
N/A

@andchiind andchiind added breaking-change A breaking change which introduces changes to the public APIs feature New feature or request Northern Lights labels Dec 6, 2024
@Eddasol
Copy link
Contributor

Eddasol commented Dec 12, 2024

Does it have to be unlocalized state? Can it be a more generic error state combined with a mqtt error message that gets propagated to the user?

@andchiind
Copy link
Contributor Author

Does it have to be unlocalized state? Can it be a more generic error state combined with a mqtt error message that gets propagated to the user?

Yeah the name is not important, but we need a state to tell the user that the robot is not offline, not running missions, but also not able to run missions. So this could also for instance include that the P-stop is active, but we might want a discussion on how fine-grained we want the states/statuses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change which introduces changes to the public APIs feature New feature or request Northern Lights
Projects
None yet
Development

No branches or pull requests

2 participants