Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider improving CLI API #125

Open
jondequinor opened this issue Jun 29, 2020 · 0 comments
Open

Consider improving CLI API #125

jondequinor opened this issue Jun 29, 2020 · 0 comments
Labels
christmas-review Issues and PRs for Christmas review enhancement major-refactor

Comments

@jondequinor
Copy link
Contributor

jondequinor commented Jun 29, 2020

Current:
--tmp has no default, is passed onto komodo.build as builddir but is largely ignored by the builders
--cache has no default, becomes outdir in komodo.fetch (which defaults to . and is created). It is also cd-ed into to ease tar and pip calls I assume. Also passed onto komodo.build as dlprefix, which is used to find e.g. find downloaded packages.
--workspace has no default, but will just become the directory from where you invoked kmd. The activators are assumed to be here if the folder exists. If the folder does not exists, the activators are copied over.
--fakeroot has no default, but becomes fakeroot = os.path.abspath(args.release) which probably has its reasons. However, in komodo.build it is either set to prefix via the cli, or to .. This is outright confusing. It's also a bool option.

cache is also not a cache the way I understand it, as things are built/moved around in there after fetching it. I think tmp is better suited to do temporary things pertaining to the build, whereas the cache could serve multiple builds.

In conjunction with #124, this setup makes komodo unnecessarily hard to understand. This is aggrevated by a bunch of cd operations.

In conjunction with #122, preparatory steps for a komod build involves copying stuff from here to there.

Can you even build komodo without cloning komodo (and of course komodo-releases)?

Maybe komodo could take a repository file, a release file, and a working directory (in addition to a prefix)? All other things should live inside komodo and the komodo pip package.

@jondequinor jondequinor changed the title Consider improving CLI API for paths Consider improving CLI API Aug 26, 2020
@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review Issues and PRs for Christmas review enhancement major-refactor
Projects
None yet
Development

No branches or pull requests

2 participants