Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement komodo as an explicit state machine #126

Open
jondequinor opened this issue Jun 30, 2020 · 0 comments
Open

Implement komodo as an explicit state machine #126

jondequinor opened this issue Jun 30, 2020 · 0 comments
Labels
christmas-review Issues and PRs for Christmas review enhancement major-refactor

Comments

@jondequinor
Copy link
Contributor

jondequinor commented Jun 30, 2020

There's an implicit state machine in komodo. Make it explicit.

(Assuming we are to expand komodo and do a major refactor)

Rationale
It might be hard to reason about some flows through komodo, especially the file operations in the end (rename, rsync, .delete, etc). Also, if one of these steps fail for some trivial reason, the most safe thing is to re-build from scratch.

So, we might have easier-to-understand code, possibility to more precisely know the state of the build, thus maybe retry from some stage.

The state machine code should not be written by us.

@jondequinor jondequinor changed the title Implement komodo as a state machine Implement komodo as an explicit state machine Jun 30, 2020
@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review Issues and PRs for Christmas review enhancement major-refactor
Projects
None yet
Development

No branches or pull requests

2 participants