Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow user python site-packages #136

Open
pinkwah opened this issue Jul 24, 2020 · 1 comment
Open

Disallow user python site-packages #136

pinkwah opened this issue Jul 24, 2020 · 1 comment
Labels
christmas-review Issues and PRs for Christmas review question

Comments

@pinkwah
Copy link
Contributor

pinkwah commented Jul 24, 2020

Komodo uses a vanilla Python interpreter, which by defaults adds ~/.local/lib/pythonX.Y/site-packges to sys.path, overriding stuff from Komodo. This will cause us headaches, such as user pip install --user a package, never updates it. We add this package to Komodo, user complains when everything breaks.

This already broke komodoenv for me, because I have an incompatible version of virtualenv in my .local/lib/pythonX.Y/site-packages. If any users expect Komodo to work like this, then we should inform them that they are doing it wrong.

Jonas' virtualenv approach already has breaking changes wrt. this: virtualenv explicitly does not add user site-packages. Depending on how long we'll keep shipping our own python binaries, we should consider disabling user site-packages via compile-flags.

Tagging @markusdregi @jondequinor and then running away to 🏖️ .

@jondequinor
Copy link
Contributor

jondequinor commented Aug 10, 2020

I somewhat agree. But I cannot find any relevant compile flags. What did you have in mind? python -s disables it runtime, but I can't find any compile time options.

On the other hand, the user is free to do what it wants.

@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review Issues and PRs for Christmas review question
Projects
None yet
Development

No branches or pull requests

3 participants