Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

komodo-transpiler needs to sort packages inside releases/matrices #158

Open
hnformentin opened this issue Sep 24, 2020 · 1 comment
Open
Labels
bug christmas-review Issues and PRs for Christmas review

Comments

@hnformentin
Copy link
Contributor

komodo-transpiler currently sorts alphabetically .yml files only for transpilled files (e.g. in release folder as 2020.10.b5-py36-rhel7.yml). The files inside releases/matrices are kept in the wrong alphabetical order (e.g. 2020.10.b5.yml). A suggestion to fix is first rewrite files in releases/matrix with write_to_file function (which sorts alphabetically) before transpile_releases function in release_transpiler.

@sondreso
Copy link
Contributor

I'm not so sure that the transpiler should sort the matrix release, since we want the matrix release to be sorted in the repository. This sounds like it belongs in the prettier (running it locally it would sort your release, and in CI it will check that your release is sorted).

@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug christmas-review Issues and PRs for Christmas review
Projects
None yet
Development

No branches or pull requests

3 participants