Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Higher order" environment variable in enable script #161

Open
pinkwah opened this issue Oct 8, 2020 · 0 comments
Open

"Higher order" environment variable in enable script #161

pinkwah opened this issue Oct 8, 2020 · 0 comments

Comments

@pinkwah
Copy link
Contributor

pinkwah commented Oct 8, 2020

See scheme in https://github.com/equinor/equilibrium/pull/37

Instead of providing multiple hardcoded environment variables, we can provide a single environment variable _PRE_KOMODO, that lists all of the environment variables that have been modified. Eg, _PRE_KOMODO=PATH:MANPATH tells a deactivate script that Komodo has been enabled previously and that PATH and MANPATH environment variables have been modified in some way.

Then, if PATH is set, it should be unset. If _PRE_KOMODO_PATH is set, export PATH=$_PRE_KOMODO_PATH and unset it.

This gives us the flexibility of changing which environment variables are set in the future, plus removes the possibility for future bugs such as #157 .

@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
@jonathan-eq jonathan-eq removed the christmas-review Issues and PRs for Christmas review label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants