Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor useEffect to start file upload in Browse.tsx, remove TS ignore #130

Open
mheggelund opened this issue Nov 7, 2023 · 1 comment
Open

Refactor useEffect to start file upload in Browse.tsx, remove TS ignore #130

mheggelund opened this issue Nov 7, 2023 · 1 comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right

Comments

@mheggelund
Copy link
Collaborator 

          I see you use the same implementation as in the example i provided. Dont add counter there, it will probably wreck something.

But you should reconsider use of the [fileToBeUpload, progress] as it should be used in useEffect.

Originally posted by @Sinrefvol in #129 (comment)
@mheggelund mheggelund added the help wanted Extra attention is needed label Nov 7, 2023
@mheggelund
Copy link
Collaborator Author

mheggelund commented Nov 7, 2023 •
edited
Loading

To be looked closer at, current solution is not optimal as it contains // eslint-disable-next-line react-hooks/exhaustive-deps to ignore TS error.

Image

@mheggelund mheggelund changed the title I see you use the same implementation as in the example i provided. Dont add counter there, it will probably wreck something. Refactor useEffect to start file upload in Browse.tsx Nov 7, 2023
@mheggelund mheggelund mentioned this issue Nov 7, 2023
Merged
@mheggelund mheggelund added the invalid This doesn't seem right label Nov 14, 2023
@mheggelund mheggelund changed the title Refactor useEffect to start file upload in Browse.tsx Refactor useEffect to start file upload in Browse.tsx, remove TS ignore Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mheggelund