From c808afc59b92cb6751a12fd5e980c7a20704be9f Mon Sep 17 00:00:00 2001
From: Wilhelm Vold <wilhelm.vold@bouvet.no>
Date: Wed, 22 Nov 2023 12:24:22 +0100
Subject: [PATCH] fix: fixed routing

---
 src/components/Table.tsx                      |  2 +-
 src/features/AppBar/Navigation/Navigation.tsx |  6 -----
 src/router.tsx                                | 25 +++++++++++++------
 3 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/src/components/Table.tsx b/src/components/Table.tsx
index b8ffcb5e..07e385dc 100644
--- a/src/components/Table.tsx
+++ b/src/components/Table.tsx
@@ -82,7 +82,7 @@ export const Table = ({ refetchKey }: { refetchKey: number }) => {
             cell: ({ row }) => (
               <Button
                 onClick={() => {
-                  navigate(`/model/${row.original.analogueModelId}/details`);
+                  navigate(`/${row.original.analogueModelId}/details`);
                 }}
               >
                 Go to model
diff --git a/src/features/AppBar/Navigation/Navigation.tsx b/src/features/AppBar/Navigation/Navigation.tsx
index be799e3a..f3cc07bf 100644
--- a/src/features/AppBar/Navigation/Navigation.tsx
+++ b/src/features/AppBar/Navigation/Navigation.tsx
@@ -1,5 +1,4 @@
 import { Tabs } from '@equinor/eds-core-react';
-import { useEffect } from 'react';
 import { useNavigate } from 'react-router-dom';
 import { tabs } from '../../../router';
 import * as Styled from './Navigation.styled';
@@ -11,11 +10,6 @@ export const Navigation = () => {
     (tab) => `/${tab.path}` === window.location.pathname,
   );
 
-  useEffect(() => {
-    const currentURL = window.location.pathname;
-    if (currentURL === '/') navigate('models');
-  }, [navigate]);
-
   function clickTab(tab: number) {
     navigate(tabs[tab].path);
   }
diff --git a/src/router.tsx b/src/router.tsx
index c4b814a4..03a49b56 100644
--- a/src/router.tsx
+++ b/src/router.tsx
@@ -15,17 +15,26 @@ interface Tab extends Required<Pick<NonIndexRouteObject, 'path' | 'element'>> {
 }
 
 const tabs: Tab[] = [
-  {
-    title: 'Models',
-    path: 'models',
-    element: <Browse />,
-  },
+  { title: 'Models', path: '/', element: <Browse /> },
   { title: 'API', path: 'api', element: <Api /> },
   { title: 'About', path: 'about', element: <About /> },
 ];
-const appRoutes = (tabs as NonIndexRouteObject[]).concat([
+
+const appRoutes = [
+  {
+    index: true,
+    element: <Browse />,
+  },
   {
-    path: 'model/:modelId/',
+    path: 'api',
+    element: <Api />,
+  },
+  {
+    path: 'about',
+    element: <About />,
+  },
+  {
+    path: ':modelId/',
     element: <Model />,
     children: [
       {
@@ -48,7 +57,7 @@ const appRoutes = (tabs as NonIndexRouteObject[]).concat([
       },
     ],
   },
-]);
+];
 
 const router = createBrowserRouter([
   {