Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #391

Open
OPMUSER opened this issue Feb 2, 2023 · 2 comments
Open

Enhancements #391

OPMUSER opened this issue Feb 2, 2023 · 2 comments

Comments

@OPMUSER
Copy link

OPMUSER commented Feb 2, 2023

@berland et al.: First of all, thank you for creating such a useful utility, and for Equinor for allowing this to be made open source.

I have a few suggestions for enhancing this already very useful package:

  • Consider adding a function to load an OPM Flow input deck, and to parse the data to obtain the SWOF tables, perhaps by loading the data into a data-frame with the first column being the table type, concatenated with the table number (perhaps SWOF-01). So something like this: swof_tables= read_data(filename='EXAMPLE.DATA', table_type='SWOF'), or something similar.
  • Add a function to plot various tables, something like thisplot_data(data=swof_tables, tables=[1, 2, 3, 4], rel_perm=True, pc=False, normalize=False, log_scale=False). The plot should be report quality, so that one can include them in reports and presentations.
  • Add a function to print various tables so that they can be used in the simulator, something like thisprint_data(data=swof_tables, tables=[1, 2, 3, 4], rel_perm=True, pc=False, normalize=False)
  • Extend the functionality to include the other Type I keywords SGOF, SLGOF, as well as SGWFN for gas-water systems.

Naturally, you may have a better way to implement the functionality, but I think the above gives you an idea of what would be a useful extension to the package.

@berland
Copy link
Collaborator

berland commented Feb 6, 2023

Thanks!

For your first suggestion, that is taken care of by the satfunc module in ecl2df

@OPMUSER
Copy link
Author

OPMUSER commented Feb 9, 2023

Many thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants