Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align test data for fmuobs with what is possible to validate #652

Open
daniel-sol opened this issue Jan 23, 2024 · 0 comments
Open

Align test data for fmuobs with what is possible to validate #652

daniel-sol opened this issue Jan 23, 2024 · 0 comments

Comments

@daniel-sol
Copy link

Including ert-doc.obs in an ert config file doesn't validate in ert as of January 2024.
Some enquiry done, and at least two things stand out:

  • BLOCK_OBSERVATIONs were deprecated sometime in 2022
  • Date fields now have to be in iso 8601 format (YYYY-MM-DD)
    The tests were not picking this up, because the OBS_CONFIG keyword was not used in testing with ert
    In my opinion the test data should validate in ert otherwise it is not a good dataset.
    Suggestion is to modify test data accordingly, but to leave the code otherwise as is, for backward compatibility.
    This should not cause problems since the changes made to ert are a narrowing down, not a widening up..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant