From ecc3ad26d4406061f85aaa67f3e46f63917f962c Mon Sep 17 00:00:00 2001 From: Matt Hall Date: Tue, 28 Feb 2023 15:04:49 +0100 Subject: [PATCH] Fix flaky test on self-hosted runner One of the Selenium tests on a plot axis title was sometimes timing out. This change doubles the timeout to 20s. For sure, 10s already seems long; if there's still an issue it may be another problem. --- tests/views/test_response_correlation.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/views/test_response_correlation.py b/tests/views/test_response_correlation.py index 4253c7c2..31d9a0b6 100644 --- a/tests/views/test_response_correlation.py +++ b/tests/views/test_response_correlation.py @@ -30,8 +30,9 @@ def test_axes_labels(mock_data, dash_duo): plot_id = plugin.uuid("response-overview") - # check that y axis label spells out "Value" - dash_duo.wait_for_text_to_equal(f"#{plot_id} text.ytitle", "Value") + # check that y axis label spells out "Value"; test is flaky so longer + # timeout. + dash_duo.wait_for_text_to_equal(f"#{plot_id} text.ytitle", "Value", timeout=20) # check that one has date, the other has index as x axis label if wanted_response == "FOPR":