-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing delta ensembles - pilot module 'SimulationTimeSeries' #812
Open
jorgenherje
wants to merge
36
commits into
equinor:main
Choose a base branch
from
jorgenherje:216-delta-ensembles-simulation-time-series
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Introducing delta ensembles - pilot module 'SimulationTimeSeries' #812
jorgenherje
wants to merge
36
commits into
equinor:main
from
jorgenherje:216-delta-ensembles-simulation-time-series
+4,113
−1,049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split code into two utils: One for fetching from back-end and another to assemble Ensemble and DeltaEnsemble objects to create new EnsembleSet
… to "Array" and more EnsembleSet: - Split override functions into separate function, and remove EnsembleType enum - Rename original getEnsembleArr() to getEnsembleArray() General: - Rename namings from "Arr" to "Array" - Move getEnsembleIdentFromString() from ensembleIdentUtils.ts to internal util for realizationFilterSettings - Remove unused hook useFirstEnsembleInEnsembleSet in WorkbenchSession.ts
From "First Ensemble" and "Second Ensemble" to "Compare Ensemble" and "Reference Ensemble"
Fix comments, minor bug fixes and adjust code
Adjust back-end after discussion with Sigurd
- Remove EnsembleInterface and EnsembleIdentInterface - Rename `Ensemble` to `RegularEnsemble`and `EnsembleIdent` to `RegularEnsembleIdent`
Handle/prevent duplicated delta ensembles in dialog
- Add unit tests - Remove isEqual func
Adjust incorrect order of RegularEnsemble arguments resulting in failing tests.
Minor fixes/adjustments based on observations during "EnsembleIdent->string"-spike
jorgenherje
requested review from
rubenthoms,
sigurdp,
HansKallekleiv and
anders-kiaer
December 13, 2024 13:54
…simulation-time-series
…ctions Based on discussion: Remove overload, and explicitly implement fixup based on argument types. As the overloads had a bug, where currIdent could be of a type, and if the type does not exist in ensembleSet, an incorrect ident would be returned for a module not supporting it. E.g. request RegularEnsembleIdent, ensemble set removes last RegularEnsembleIdent, then DeltaEnsembleIdent is returned, and the module might get error scenario.
anders-kiaer
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in the context of user testing (including Johan Sverdrup user representatives). Looks good! 👍
jorgenherje
changed the title
216 delta ensembles simulation time series
Introducing delta ensembles - pilot module 'SimulationTimeSeries'
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of Delta Ensembles
Definition:
DeltaEnsemble = CompareEnsemble - ReferenceEnsemble
This PR introduces framework logic to create, propagate and provide delta ensembles to modules. Implemented use of delta ensemble in
SimulationTimeSeries
-module, which introduces two new end-points for vector summary data: individual realization vectors and statistical vectors for delta ensembles.Front-end:
Framework:
Functionality for creating delta ensembles
Introducing two type of ensembles and idents:
Ensemble
toRegularEnsemble
RegularEnsemble
andDeltaEnsemble
RegularEnsembleIdent
andDeltaEnsembleIdent
Restructure
EnsembleSet
:regularEnsembleArray: RegularEnsemble[];
deltaEnsembleArray: DeltaEnsemble[];
Allow delta ensembles in
RealizationFilter
.Define and propagate delta ensembles to modules
Components:
EnsembleDropdown
andEnsembleSelect
handleDeltaEnsemble
as an opt-in.Modules:
SimulationTimeSeries
-moduleBack-end:
General fixes/adjustments
handleApplyAllClick()
inrealizationFilterSettings.tsx
: added missing notification of realization filter change for subscribers (did not affect when closing drawer).useFirstEnsembleInEnsembleSet
inWorkbenchSession.ts
Closes: #216
Closes: #538