Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor XYZ base class methods dependent on derived classes #1162

Open
mferrera opened this issue Feb 12, 2024 · 0 comments
Open

Refactor XYZ base class methods dependent on derived classes #1162

mferrera opened this issue Feb 12, 2024 · 0 comments

Comments

@mferrera
Copy link
Collaborator

mferrera commented Feb 12, 2024

Some methods in XYZ have a dependency on instances of classes derived from it. For example,

def operation_polygons_v2(self, poly, value, opname="add", inside=True, where=True):

This function is "part of" the XYZ class but expects poly to be a Polygons instance, which is a class derived from XYZ.

Not clear if just making these abstract methods in XYZ is the best choice, there might be a better one.

There might be other cases of this in which _xyz_something.py modules are imported into subclass modules.

@mferrera mferrera assigned mferrera and unassigned mferrera Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant