From 6d3fae8ddf710fdcf233c763bd8aa60fb984730a Mon Sep 17 00:00:00 2001 From: Fangting Liu Date: Thu, 29 Aug 2024 13:31:40 -0700 Subject: [PATCH] update wording on expected behaviors of val/exec installs --- standard/ERCs/erc-6900.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/standard/ERCs/erc-6900.md b/standard/ERCs/erc-6900.md index d50559c7..2138c218 100644 --- a/standard/ERCs/erc-6900.md +++ b/standard/ERCs/erc-6900.md @@ -493,18 +493,18 @@ An execution function selector MUST not conflict with native ERC-4337 and ERC-69 During execution installation, the account MUST correctly set flags and other fields based on the incoming data and module manifest provided by users. -- the account MUST install all execution functions and set flags and fields accordingly as specified in the manifest. +- the account MUST install all execution functions and set flags and fields as specified in the manifest. - the account MUST add all execution hooks as specified in the manifest. -- the account MUST add all supported interfaces as specified in the manifest. -- the account MUST call `onInstall` on the execution module to initialize the states. +- the account SHOULD add all supported interfaces as specified in the manifest. +- the account SHOULD call `onInstall` on the execution module to initialize the states if required by user. - the account MUST emit `ExecutionInstalled` as defined in the interface for all installed executions. During execution uninstallation, the account MUST correctly clear flags and other fields based on the incoming data and module manifest provided by users. -- the account MUST remove all execution functions and clear flags and fields accordingly as specified in the manifest. +- the account MUST remove all execution functions and clear flags and fields as specified in the manifest. - the account MUST remove all execution hooks as specified in the manifest. - the account MUST remove all supported interfaces as specified in the manifest. -- the account MUST call `onUnInstall` on the execution module to initialize the states and track call success. +- the account SHOULD call `onUnInstall` on the execution module to initialize the states and track call success if required by user. - the account MUST emit `ExecutionUninstalled` as defined in the interface for all uninstalled executions. #### Responsibilties of `StandardExecutor` and `ModuleExecutor`