diff --git a/src/account/AccountLoupe.sol b/src/account/AccountLoupe.sol index becffdec..9a5a25c6 100644 --- a/src/account/AccountLoupe.sol +++ b/src/account/AccountLoupe.sol @@ -8,7 +8,6 @@ import {EnumerableSet} from "@openzeppelin/contracts/utils/structs/EnumerableSet import { AccountStorage, getAccountStorage, - getPermittedCallKey, HookGroup, toFunctionReferenceArray } from "./AccountStorage.sol"; diff --git a/src/account/PluginManagerInternals.sol b/src/account/PluginManagerInternals.sol index 5707b7d8..e2a10863 100644 --- a/src/account/PluginManagerInternals.sol +++ b/src/account/PluginManagerInternals.sol @@ -9,7 +9,6 @@ import { AccountStorage, getAccountStorage, SelectorData, - PermittedCallData, getPermittedCallKey, HookGroup, PermittedExternalCallData @@ -44,8 +43,6 @@ abstract contract PluginManagerInternals is IPluginManager { error PluginNotInstalled(address plugin); error RuntimeValidationFunctionAlreadySet(bytes4 selector, FunctionReference validationFunction); error UserOpValidationFunctionAlreadySet(bytes4 selector, FunctionReference validationFunction); - error PluginApplyHookCallbackFailed(address providingPlugin, bytes revertReason); - error PluginUnapplyHookCallbackFailed(address providingPlugin, bytes revertReason); modifier notNullFunction(FunctionReference functionReference) { if (functionReference.isEmpty()) { diff --git a/src/interfaces/IPlugin.sol b/src/interfaces/IPlugin.sol index 028e5205..c02bc207 100644 --- a/src/interfaces/IPlugin.sol +++ b/src/interfaces/IPlugin.sol @@ -3,8 +3,6 @@ pragma solidity ^0.8.19; import {UserOperation} from "@eth-infinitism/account-abstraction/interfaces/UserOperation.sol"; -import {IPluginManager} from "./IPluginManager.sol"; - // Forge formatter will displace the first comment for the enum field out of the enum itself, // so annotating here to prevent that. // forgefmt: disable-start diff --git a/src/plugins/BasePlugin.sol b/src/plugins/BasePlugin.sol index 1dda832d..5dbcb2b3 100644 --- a/src/plugins/BasePlugin.sol +++ b/src/plugins/BasePlugin.sol @@ -5,7 +5,6 @@ import {UserOperation} from "@eth-infinitism/account-abstraction/interfaces/User import {ERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol"; import {IPlugin, PluginManifest, PluginMetadata} from "../interfaces/IPlugin.sol"; -import {IPluginManager} from "../interfaces/IPluginManager.sol"; /// @title Base contract for plugins /// @dev Implements ERC-165 to support IPlugin's interface, which is a requirement diff --git a/test/account/AccountExecHooks.t.sol b/test/account/AccountExecHooks.t.sol index 79ce096b..957bcb56 100644 --- a/test/account/AccountExecHooks.t.sol +++ b/test/account/AccountExecHooks.t.sol @@ -4,9 +4,6 @@ pragma solidity ^0.8.19; import {ECDSA} from "@openzeppelin/contracts/utils/cryptography/ECDSA.sol"; import {EntryPoint} from "@eth-infinitism/account-abstraction/core/EntryPoint.sol"; -import {UpgradeableModularAccount} from "../../src/account/UpgradeableModularAccount.sol"; -import {FunctionReference, FunctionReferenceLib} from "../../src/helpers/FunctionReferenceLib.sol"; -import {IPluginManager} from "../../src/interfaces/IPluginManager.sol"; import { IPlugin, ManifestAssociatedFunctionType, @@ -16,6 +13,8 @@ import { PluginManifest } from "../../src/interfaces/IPlugin.sol"; import {SingleOwnerPlugin} from "../../src/plugins/owner/SingleOwnerPlugin.sol"; +import {UpgradeableModularAccount} from "../../src/account/UpgradeableModularAccount.sol"; +import {FunctionReference, FunctionReferenceLib} from "../../src/helpers/FunctionReferenceLib.sol"; import {MockPlugin} from "../mocks/MockPlugin.sol"; import {MSCAFactoryFixture} from "../mocks/MSCAFactoryFixture.sol"; diff --git a/test/account/ManifestValidity.t.sol b/test/account/ManifestValidity.t.sol index 28a2ddff..85a845de 100644 --- a/test/account/ManifestValidity.t.sol +++ b/test/account/ManifestValidity.t.sol @@ -3,6 +3,7 @@ pragma solidity ^0.8.19; import {EntryPoint} from "@eth-infinitism/account-abstraction/core/EntryPoint.sol"; +import {UpgradeableModularAccount} from "../../src/account/UpgradeableModularAccount.sol"; import {PluginManagerInternals} from "../../src/account/PluginManagerInternals.sol"; import {UpgradeableModularAccount} from "../../src/account/UpgradeableModularAccount.sol"; import {FunctionReference} from "../../src/helpers/FunctionReferenceLib.sol"; diff --git a/test/account/UpgradeableModularAccount.t.sol b/test/account/UpgradeableModularAccount.t.sol index 3a697393..02a5b3b1 100644 --- a/test/account/UpgradeableModularAccount.t.sol +++ b/test/account/UpgradeableModularAccount.t.sol @@ -13,7 +13,6 @@ import {FunctionReference} from "../../src/helpers/FunctionReferenceLib.sol"; import {IPlugin, PluginManifest} from "../../src/interfaces/IPlugin.sol"; import {IAccountLoupe} from "../../src/interfaces/IAccountLoupe.sol"; import {IPluginManager} from "../../src/interfaces/IPluginManager.sol"; -import {IPluginExecutor} from "../../src/interfaces/IPluginExecutor.sol"; import {Call} from "../../src/interfaces/IStandardExecutor.sol"; import {SingleOwnerPlugin} from "../../src/plugins/owner/SingleOwnerPlugin.sol"; import {TokenReceiverPlugin} from "../../src/plugins/TokenReceiverPlugin.sol"; diff --git a/test/plugin/TokenReceiverPlugin.t.sol b/test/plugin/TokenReceiverPlugin.t.sol index 3c290f2e..49692e34 100644 --- a/test/plugin/TokenReceiverPlugin.t.sol +++ b/test/plugin/TokenReceiverPlugin.t.sol @@ -10,7 +10,6 @@ import {IERC1155Receiver} from "@openzeppelin/contracts/token/ERC1155/IERC1155Re import {UpgradeableModularAccount} from "../../src/account/UpgradeableModularAccount.sol"; import {FunctionReference} from "../../src/helpers/FunctionReferenceLib.sol"; -import {IPluginManager} from "../../src/interfaces/IPluginManager.sol"; import {TokenReceiverPlugin} from "../../src/plugins/TokenReceiverPlugin.sol"; import {MSCAFactoryFixture} from "../mocks/MSCAFactoryFixture.sol";