Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider a separate send queue for PONG #107

Open
slingamn opened this issue Jun 11, 2024 · 0 comments
Open

consider a separate send queue for PONG #107

slingamn opened this issue Jun 11, 2024 · 0 comments

Comments

@slingamn
Copy link
Member

<JAA> In most non-trivial implementations I've seen, 'sending' actually adds to a queue, and the real sender throttles everything, but PONGs bypass the queue.
<slingamn> we don't have any special casing for PONG
<JAA> I'm not sure I've ever seen anything else bypass, although I bet there are exceptions.
<JAA> So if you build enough of a queue, you'll get disconnected with a ping timeout?

This is unlikely to come up in practice, but it's a theoretical possibility, We could add a second pwrite queue that just processes PONG. (select fairness would sort it out unless we get very unlucky; we could also deterministically favor the PONG queue by first doing a nonblocking select from the PONG queue, then a blocking select from both queues.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant