Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Prevent downloading images when building product #31

Open
kardi31 opened this issue Jul 21, 2021 · 0 comments
Open

Prevent downloading images when building product #31

kardi31 opened this issue Jul 21, 2021 · 0 comments

Comments

@kardi31
Copy link
Contributor

kardi31 commented Jul 21, 2021

Bug type

Architecture

Current behavior

When Ergonode is building products & synchronising product images, it downloads remotely whole image content. The content is not used at all, but it takes a lot of time to download the image through API (10sec/image in our case).

Input Code

https://github.com/ergonode/exporter-shopware-6-backend/blob/main/src/Infrastructure/Client/Shopware6ProductMediaClient.php#L150

Expected behavior

Do not download image through API. Ergonode as PIM should be a source of truth, we should not care about the content of image on remote server.

Possible Solution

When sending GET request to remote server, all we need to verify is whether response is successful & not empty. We should ignore the content of image.

Environment


Ergonode version: 1.0.1

 
Detailed information:
- PHP version:  7.4

Others:

cc @wfajczyk @piotrkreft

kardi31 added a commit to StrixRedTeam/exporter-shopware-6-backend that referenced this issue Jul 21, 2021
kardi31 added a commit to StrixRedTeam/exporter-shopware-6-backend that referenced this issue Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant