Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLmin is not fully compatible with Angular #82

Open
MichielDeMey opened this issue Mar 4, 2014 · 3 comments
Open

HTMLmin is not fully compatible with Angular #82

MichielDeMey opened this issue Mar 4, 2014 · 3 comments

Comments

@MichielDeMey
Copy link

Hi

I'm just letting you know that html-minifier (https://github.com/kangax/html-minifier/), which is used by grunt-usemin is not fully compatible with AngularJS.

AngularJS has support for inline JSON, but html-minifier actually escapes inline JSON.
Please see Issue 98 for more information on this.
(kangax/html-minifier#98 (comment))

A way to work around this is simply by not using the htmlmin option in the ngTemplates grunt task. As of now, there is no option to configure this.

You might want to document this behaviour. :)

@ericclemmons
Copy link
Owner

I'm going to remove htmlmin. What a PITA that "feature" has been.

@brandon-arnold
Copy link

Second removing the htmlmin feature. I discovered that it was removing the type="text" attributes from all input tags in my templates!

@brandon-arnold
Copy link

Specifically, it's the removeScriptTypeAttributes option. But they aren't script type attributes; they're input type attributes. Seems a little buggy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants