New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cached data after use #79

Open

ericclemmons opened this issue Sep 7, 2015 · 1 comment

Labels

bug

Milestone

Owner

ericclemmons commented Sep 7, 2015

This probably needs a test case to confirm, but the thinking is that cached data will be re-used for the same object repeatedly:

react-resolver/src/Resolver.js

Lines 114 to 122 in 6c964c8

cached(resolver = this) {

const id = resolver[ID];

if (this.props.data.hasOwnProperty(id)) {

return { ...this.props.data[id] };

} else if (this.context.resolver) {

return this.context.resolver.cached(resolver);

}

}

ericclemmons added the bug label

ericclemmons added this to the v2 milestone

Owner Author

ericclemmons commented Sep 7, 2015

This could negate the need for #73 since data isn't stored after resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment