-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for TransitionGroup #89
Comments
I haven't used ReactCSSTransitionGroup, but I'd imagine it's because of the HoC. If the I'd have to actually use it to see how the two would play together... |
basically, if the component resolves (does not renders right away), it won't work (at least on my side). I have been able to try on the examples too (#77). I'd be quite interest to know an alternative, or just your idea about transitioning pages with the resolver. I've had random better results with this (https://github.com/Khan/react-components/blob/master/examples/timeout-transition-group.jsx). In any case, csstransitiongroup relies on transitionStart/End events, that does not seem that robust |
@bbnnt I'll be adding & publishing a @transition(ReactCSSTransitionGroup, { ...props })
@resolve("user", () => someLongRequest)
class UserProfile ... Similar to That's the problem: The transition is running against an empty element because the data hasn't loaded yet. |
sounds great! |
Well I'm not 100% sure the problem relies here; but from what I understood so far, you seem to loose the ability to use the transition groups (or csstransitiongroups), because of the resolving
Glad to get some help on this one in any case
The text was updated successfully, but these errors were encountered: