-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shinymaterial app fails to run without internet connection #103
Comments
This code was unchanged in the update (L85 of shiny-material-page.R). Trying to determine the issue now. |
|
Thanks, @ericrayanderson, this seems to work. I see that it generates subfolder in the shiny web root called icons where it copies the font. This is totally ok for me. I know that Google recommends to load fonts from the web, but from a regular developer point of view I would (totally) consider it bad design that general UI has run-time dependencies to a foreign web server, so I wouldn't make it a default (like I suppose regular shiny application do). Also, there are some efforts to maintain and host the icons in an open way (Google's repo is currently unmaintained), in case you want to remove Google dependencies (I suppose they do some kind of tracking) or simply update the icon set: |
Oh interesting, did not know about the open source hosting of the icons. I updated a branch that hopefully resolves issue #97, as well. |
Thanks for your efforts. When I run a a shinymaterial app and try to serve the contained font this will not work if the www folder is read-only. Is there a way to deposit the fonts there before with a deterministic name?
|
It seems that the builtin theme in the current stable version pulls some Google fonts. Therefore, when loading the app while running it locally without internet access, the app fails complains with the sentence
This is related to the default way to replace the default CSS in #97.
The text was updated successfully, but these errors were encountered: