Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-visit: do we still need mdbxgo_cursor_get1 helpers? #145

Closed
AskAlexSharov opened this issue Jun 15, 2024 · 0 comments · Fixed by #148
Closed

Re-visit: do we still need mdbxgo_cursor_get1 helpers? #145

AskAlexSharov opened this issue Jun 15, 2024 · 0 comments · Fixed by #148
Assignees
@JkLondon

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented Jun 15, 2024 •
edited
Loading

After make CGO cheaper: #142 - we can re-visit mdbxgo_cursor_get1 helpers - i guess we needed them only to create MDBX_val inside C. But maybe it's not necessary anymore and we can use mdbx_cursor_get directly.

Maybe you will need add benchmarks which will trigger getVal0/getVal01/getVal1/getVal2 before moving forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JkLondon JkLondon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New setval approach erigontech/mdbx-go
2 participants
@AskAlexSharov @JkLondon