Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain #5

Open
erikjanwestendorp opened this issue Aug 24, 2020 · 4 comments
Open

Add domain #5

erikjanwestendorp opened this issue Aug 24, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@erikjanwestendorp
Copy link
Owner

erikjanwestendorp commented Aug 24, 2020

It would be nice if a new domain could be added from the dashboard, similar to the way languages ​​are added. When adding a domain it should be possible to choose the language, for example with a dropdown, enter a domain name and assign it to a content node.

@erikjanwestendorp erikjanwestendorp self-assigned this Aug 24, 2020
@erikjanwestendorp erikjanwestendorp added the enhancement New feature or request label Aug 24, 2020
@erikjanwestendorp erikjanwestendorp added the help wanted Extra attention is needed label Sep 5, 2020
@ronaldbarendse
Copy link

Just note that domains might get a sort order in the future (umbraco/Umbraco-CMS#8316) and wildcard domains (no domain name, only setting the node culture) can only be added once per node.

@callumbwhyte
Copy link

Hey @erikjanwestendorp!

I love this package (should be the way domains are handled in Core IMHO!) and this feature would be great.

I'm going to work on a PR for this during my stream today!

Cheers,
Callum

@ronaldbarendse
Copy link

@callumbwhyte Just know that Umbraco has quite a bit of business logic (or domain logic 😁) in the ContentController, instead of the DomainService:
https://github.com/umbraco/Umbraco-CMS/blob/e9627f2ee962a73cd8c007a42845c9129e3339ee/src/Umbraco.Web/Editors/ContentController.cs#L1721-L1871

@erikjanwestendorp
Copy link
Owner Author

@callumbwhyte Thank you! Great that you want to work on it! I look forward to your PR :-)! I will definitely watch the stream! I assigned the issue to you!

@ronaldbarendse Thanks for your help as well, really appreciate that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants