Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: tolerate malformed SSH_MSG_IGNORE messages #9213

Open
alexandrejbr opened this issue Dec 18, 2024 · 0 comments · May be fixed by #9214
Open

ssh: tolerate malformed SSH_MSG_IGNORE messages #9213

alexandrejbr opened this issue Dec 18, 2024 · 0 comments · May be fixed by #9214

Comments

@alexandrejbr
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some SSH implementations, like SSHJ, can send an arguably malformed SSH_MSG_IGNORE message, i.e. sending just the type and not sending the actually data string.

openssh seems to accept this and as we talked before you seem to want to be inline with openssh. If that is the case being less strict with this messages could be an option.

Describe the solution you'd like
This is not so much a feature request but more sharing the information and letting you decide what do you think it's best for the erlang ssh application, if to keep being this strict in this case or being more relaxed as openssh is. I don't have a strong opinion on what is the best.

I have implemented a simple fix that I will be sharing in a PR so it's easier for you in case you want to accept this.

alexandrejbr added a commit to alexandrejbr/otp that referenced this issue Dec 18, 2024
@alexandrejbr alexandrejbr linked a pull request Dec 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant