Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable assert-checking for CI #139

Closed
erthink opened this issue Aug 20, 2017 · 1 comment
Closed

Enable assert-checking for CI #139

erthink opened this issue Aug 20, 2017 · 1 comment
Assignees
@erthink
Labels
enhancement p2-major

Comments

@erthink
Copy link
Owner

erthink commented Aug 20, 2017

Otherwise not all errors can be identified in a timely manner, especially in pull-request.
@erthink erthink self-assigned this Aug 20, 2017
@erthink erthink mentioned this issue Aug 20, 2017
Merged
erthink added a commit that referenced this issue Aug 20, 2017
@erthink
reopenldap: revert changes related to 'cppcheck'.
1aa161d 
This revert commits:
 1. 29cc141, "resolve several issues found by cppcheck:"
 2. d8ab714, "resolve cppcheck warnings:".

In general, seems cppcheck is not enough smart (related to
Coverity) to recognize a pattern: where one or more assert()
are used to check pre-conditions and the following code check
same conditions and return error.

Related to #139
Related to #136

Change-Id: I28dce5aac008ec1c14907cb01e4049e26f4992b8
@erthink
Copy link
Owner Author

erthink commented Aug 20, 2017

#140

@erthink erthink closed this as completed Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erthink erthink

Labels
enhancement p2-major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erthink