-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitattributes #896
base: master
Are you sure you want to change the base?
Conversation
@@ -2,5 +2,4 @@ | |||
/test export-ignore | |||
/.gitattributes export-ignore | |||
/.gitignore export-ignore | |||
/.travis.yml export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add .github
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review. I will keep my PR as is.
My intention is to delete a thing that no longer exist.
When the file is cleaned up, it can be improved further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can click apply on my suggestion
that will make your pr more accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can create your own PR if you want.
As I've said, my intention is different. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in #905
@@ -2,5 +2,4 @@ | |||
/test export-ignore | |||
/.gitattributes export-ignore | |||
/.gitignore export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/.gitignore export-ignore | |
/.gitignore export-ignore | |
/.github export-ignore |
Hello,
This PR removes a redundant
.travis.yml
file from.gitattributes
.