Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitattributes #896

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kudashevs
Copy link

Hello,

This PR removes a redundant .travis.yml file from .gitattributes.

@@ -2,5 +2,4 @@
/test export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
/.travis.yml export-ignore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add .github instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. I will keep my PR as is.

My intention is to delete a thing that no longer exist.
When the file is cleaned up, it can be improved further.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can click apply on my suggestion
that will make your pr more accurate

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create your own PR if you want.

As I've said, my intention is different. Thank you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in #905

@@ -2,5 +2,4 @@
/test export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/.gitignore export-ignore
/.gitignore export-ignore
/.github export-ignore

@williamdes williamdes mentioned this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants