Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transparent colors aren't converted to hex properly (alpha is dropped) #23

Closed
Janiczek opened this issue Mar 22, 2018 · 1 comment
Closed

Transparent colors aren't converted to hex properly (alpha is dropped) #23

Janiczek opened this issue Mar 22, 2018 · 1 comment

Comments

@Janiczek
Copy link
Contributor

The function concerned is colorToHex. Ignores the alpha field of the toRgb record and it probably shouldn't.

Here's a relevant caniuse.com chart.
The best solution is probably to generate a #rrggbb if alpha == 1 and #rrggbbaa otherwise?

This issue surfaced in terezka/line-charts#40.
@eskimoblood
Copy link
Owner

@Janiczek could you please add a pull request for this, as I have no time to work on this at the moment.

@Janiczek Janiczek mentioned this issue Mar 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eskimoblood @Janiczek