Save AMI set zip file in permanent instead of temporary storage

[aksm]

What?

Zip files for AMI sets were previously saved in permanent storage but are currently saved in temporary, e.g. /system/temporary?file=ami/files.zip instead of /sites/default/files/2021/11/files.zip.

Per @DiegoPino probably the following needs to be added somewhere:

$file->setPermanent();
$file->save();
// Add to file usage calculation.
\Drupal::service('file.usage')->add($file, 'my_module_name', 'file', $file->id());

[DiegoPino]

@aksm @alliomeria ok, false alarm! Just did a lot of testing and the fact that its in tmp:// does not mean its not permanent. Drupal won't delete it automatically. I actually deleted the file (checked my terminal logs, it was me) when cleaning up.

I also have an inline/code documentation explaining why its going into temporary://ami and not public:// or private://
The reason is, that until the Entity is saved (the AMI) the file itself can not be accessed by the user (download link after uploading) because Drupal needs any file to be attached to an entity before allowing permission. Once the entity is saved all goes well.

So. The way it is works. But for safety I could move the file after saving to a more "secure" location if needed?
Let's talk this out, but at least its not broken, it was me messing up with the storage layer.

Hugs

[DiegoPino]

WE should revisit this. Also we have seen ZIP file name conflicts in the past