Make use of arc4random_buf() #1640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of arc4random_buf() if it exists. Supported on FreeBSD/NetBSD/OpenBSD/Solaris/Linux/Android.
|
Ping. |
|
Thank you for the pull request! Considering the readentropy() function is only used to randomize the payload in iperf3 streams to avoid compression, I'm not sure what benefit using arc4random_buf() would bring. Could you explain the advantages? |
|
Thank you for the pull request. If you'd like to discuss the benefits of this change, we can revisit it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of arc4random_buf() if it exists. Supported on
FreeBSD/NetBSD/OpenBSD/Solaris/Linux/Android.