Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show preview wont hide "Attach a file" button #5

Open
tvb opened this issue May 12, 2014 · 4 comments
Open

Show preview wont hide "Attach a file" button #5

tvb opened this issue May 12, 2014 · 4 comments

Comments

@tvb
Copy link
Contributor

tvb commented May 12, 2014

screen shot 2014-05-12 at 21 42 46

@tobyzerner
Copy link
Member

I don't think this is an issue. Maybe not ideal, but since attachments don't show up in the preview anyway, it's probably better to leave the attachments area displaying.

@tvb
Copy link
Contributor Author

tvb commented May 13, 2014

Define "issue" here. It is not an issue preventing it from working indeed but it is rather a cosmetic issue. Since I have no seperate place for reporting cosmetic issues I wrote it down here.

Anyway, imo attachments should be shown in preview, just like GitHub does, but only if they are added to the conversation. Because you want to "preview" the writing which includes attachments at that point.

And besides, I don't see any reason for the "Attach a file" inside a preview window. So I don't see why this would be better..

@tobyzerner
Copy link
Member

I guess by any definition it is valid "issue" — I just don't think it's a big enough issue to worry about (more trouble than it's worth.) I do agree that ideally attachments should be rendered properly in the preview. But this is just an ideal; the current behaviour doesn't really subtract from usability at all.

So I'll tell you what, I'll reopen this, but don't expect me to fix it anytime soon :P

@tobyzerner tobyzerner reopened this May 13, 2014
@tvb
Copy link
Contributor Author

tvb commented May 13, 2014

<3, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants