Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate KSZ8863 driver to new I2C driver implementation #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bogdankolendovskyy
Copy link
Collaborator

Description

Migrate KSZ8863 driver to use i2c_master.h instead of legacy i2c.h. Examples updated accrodingly, and ioctl error

E (447) esp.emac: emac_esp_custom_ioctl(276): unknown io command: 4109

suppressed. It resulted from ETHERNET_EVENT_CONNECTED handler trying to use KSZ8863 custom ioctl command KSZ8863_ETH_CMD_G_PORT_NUM when host_eth_handle produced ETHERNET_EVENT_CONNECTED.

Related

Fixes #45

Testing

I2C bus probed to verify correct data transfer, examples are confirmed to be running without issues.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@kostaond
Copy link
Collaborator

ksz8863/CMakeLists.txt Outdated Show resolved Hide resolved
ksz8863/src/ksz8863_ctrl.c Outdated Show resolved Hide resolved
ksz8863/src/ksz8863_ctrl.c Outdated Show resolved Hide resolved
ksz8863/src/ksz8863_ctrl.c Show resolved Hide resolved
@bogdankolendovskyy bogdankolendovskyy force-pushed the ksz8863_new_i2c_dev branch 2 times, most recently from 54d4049 to 947cfb7 Compare December 6, 2024 12:22
ksz8863/src/ksz8863_ctrl.c Outdated Show resolved Hide resolved
@kostaond
Copy link
Collaborator

kostaond commented Dec 9, 2024

@bogdankolendovskyy don't forget to update idf_component.yml. Please also check the new I2C driver is available in IDFv5.3 which stated as dependency for KS8863.

@bogdankolendovskyy bogdankolendovskyy force-pushed the ksz8863_new_i2c_dev branch 2 times, most recently from 7056470 to dd0d710 Compare December 10, 2024 13:02
@kostaond
Copy link
Collaborator

kostaond commented Jan 6, 2025

@bogdankolendovskyy don't forget to update idf_component.yml. Please also check the new I2C driver is available in IDFv5.3 which stated as dependency for KS8863.

Please don't forget on this comment.

@bogdankolendovskyy
Copy link
Collaborator Author

@bogdankolendovskyy don't forget to update idf_component.yml. Please also check the new I2C driver is available in IDFv5.3 which stated as dependency for KS8863.

Forgot to reply here. I've tested that it builds and runs with v5.3. What other changes to idf_component.yml are needed in your opinion ?

@kostaond
Copy link
Collaborator

kostaond commented Jan 7, 2025

@bogdankolendovskyy don't forget to update idf_component.yml. Please also check the new I2C driver is available in IDFv5.3 which stated as dependency for KS8863.

Forgot to reply here. I've tested that it builds and runs with v5.3. What other changes to idf_component.yml are needed in your opinion ?

We need to increase the version so the driver was updated at Component registry. We currently still missing proper bump process at this repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KSZ8863 - I2C Migration, ioctl error suppression (IDFGH-13977)
2 participants