-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate KSZ8863 driver to new I2C driver implementation #46
base: master
Are you sure you want to change the base?
Migrate KSZ8863 driver to new I2C driver implementation #46
Conversation
7af04fb
to
c0f1edf
Compare
Please double check if CMakelists needs to be updated too https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/peripherals/i2c.html?highlight=i2c_master_transmit#api-reference |
c0f1edf
to
6d7e870
Compare
6d7e870
to
9ec466d
Compare
54d4049
to
947cfb7
Compare
@bogdankolendovskyy don't forget to update |
7056470
to
dd0d710
Compare
Please don't forget on this comment. |
Forgot to reply here. I've tested that it builds and runs with v5.3. What other changes to |
We need to increase the version so the driver was updated at Component registry. We currently still missing proper bump process at this repo... |
5c310a0
to
b93284f
Compare
b93284f
to
e2d2872
Compare
Description
Migrate KSZ8863 driver to use
i2c_master.h
instead of legacyi2c.h
. Examples updated accrodingly, and ioctl errorsuppressed. It resulted from
ETHERNET_EVENT_CONNECTED
handler trying to use KSZ8863 custom ioctl commandKSZ8863_ETH_CMD_G_PORT_NUM
whenhost_eth_handle
producedETHERNET_EVENT_CONNECTED
.Related
Fixes #45
Testing
I2C bus probed to verify correct data transfer, examples are confirmed to be running without issues.
Checklist
Before submitting a Pull Request, please ensure the following: