service port=0 in mdns_service_add causes a error (IDFGH-13429)

[nopnop2002]

Answers checklist.

• I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
• I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
• I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.

v5.2.2-420-gc4fc74a6de

Espressif SoC revision.

Chip is ESP32D0WDQ6 (revision 1)

Operating System used.

Linux

How did you build your project?

Command line with CMake

If you are using Windows, please specify command line type.

None

Development Kit.

ESP32 Development Board

Power Supply used.

USB

What is the expected behavior?

service port=0 in mdns_service_add not causes a error.

What is the actual behavior?

service port=0 in mdns_service_add causes a error

Steps to reproduce.

    //initialize mDNS
    ESP_ERROR_CHECK( mdns_init() );
    //set mDNS hostname (required if you want to advertise services)
    ESP_ERROR_CHECK( mdns_hostname_set(CONFIG_MY_HOSTNAME));
    ESP_LOGI(TAG, "mdns hostname set to: [%s]", CONFIG_MY_HOSTNAME);

    //initialize service
    //ESP_ERROR_CHECK( mdns_service_add(NULL, "_device-info", "_tcp", 80, NULL, 0) );
    ESP_ERROR_CHECK( mdns_service_add(NULL, "_device-info", "_tcp", 0, NULL, 0) );

Debug Logs.

ESP_ERROR_CHECK failed: esp_err_t 0x102 (ESP_ERR_INVALID_ARG) at 0x400d69ae
0x400d69ae: initialise_mdns at /home/nop/rtos/esp-idf-mdns/query-host1/main/main.c:144 (discriminator 1)

file: "./main/main.c" line 144
func: initialise_mdns
expression: mdns_service_add(NULL, "_device-info", "_tcp", 0, NULL, 0)

abort() was called at PC 0x40089257 on core 0
0x40089257: _esp_error_check_failed at /home/nop/esp-idf/components/esp_system/esp_err.c:50

More Information.

The samba service on the Linux server registers the service on port #445 and #0.

$ avahi-browse -art
+ enp2s0 IPv6 VOYAGER                                       _device-info._tcp    local
+ enp2s0 IPv4 VOYAGER                                       _device-info._tcp    local
+ enp2s0 IPv6 VOYAGER                                       Microsoft Windows Network local
+ enp2s0 IPv4 VOYAGER                                       Microsoft Windows Network local

= enp2s0 IPv6 VOYAGER                                       Microsoft Windows Network local
   hostname = [voyager.local]
   address = [fe80::78dc:5b71:a1bd:380a]
   port = [445]
   txt = []
= enp2s0 IPv6 VOYAGER                                       _device-info._tcp    local
   hostname = [voyager.local]
   address = [fe80::78dc:5b71:a1bd:380a]
   port = [0]
   txt = ["model=MacSamba"]
= enp2s0 IPv4 VOYAGER                                       Microsoft Windows Network local
   hostname = [voyager.local]
   address = [192.168.10.39]
   port = [445]
   txt = []
= enp2s0 IPv4 VOYAGER                                       _device-info._tcp    local
   hostname = [voyager.local]
   address = [192.168.10.39]
   port = [0]
   txt = ["model=MacSamba"]

It works correctly unless port # is 0.
However, Service Type in device-info does not have port #.

    //initialize mDNS
    ESP_ERROR_CHECK( mdns_init() );
    //set mDNS hostname (required if you want to advertise services)
    ESP_ERROR_CHECK( mdns_hostname_set(CONFIG_MY_HOSTNAME));
    ESP_LOGI(TAG, "mdns hostname set to: [%s]", CONFIG_MY_HOSTNAME);

    //initialize service
    ESP_ERROR_CHECK( mdns_service_add(NULL, "_device-info", "_tcp", 80, NULL, 0) );
    //ESP_ERROR_CHECK( mdns_service_add(NULL, "_device-info", "_tcp", 0, NULL, 0) );

$ avahi-browse -art
= enp2s0 IPv4 esp32-mdns1                                   _device-info._tcp    local
   hostname = [esp32-mdns1.local]
   address = [192.168.10.115]
   port = [80]
   txt = []

About device-info

http://www.dns-sd.org/servicetypes.html

device-info     Device Info
                Stuart Cheshire <cheshire at apple.com>, Marc Krochmal <marc at apple.com>
                Not a service type. Special name reserved for DNS-SD device info.

[david-cermak]

Thanks for reporting, fixing in espressif/esp-protocols#730

[nopnop2002]

@david-cermak

With this fix, will the following code work?

ESP_ERROR_CHECK( mdns_service_add(NULL, "_device-info", "_tcp", 0, NULL, 0) );

[david-cermak]

Seems like it:

    ESP_ERROR_CHECK( mdns_init() );
    ESP_ERROR_CHECK( mdns_hostname_set(hostname) );
    ESP_LOGI(TAG, "mdns hostname set to: [%s]", hostname);
    ESP_ERROR_CHECK( mdns_instance_name_set(EXAMPLE_MDNS_INSTANCE) );
    ESP_ERROR_CHECK( mdns_service_add(NULL, "_device-info", "_tcp", 0, NULL, 0) );

$ avahi-browse -a -r
+ enpxxxx IPv6 ESP32 with mDNS                               _device-info._tcp    local
= enpxxxx IPv6 ESP32 with mDNS                               _device-info._tcp    local
   hostname = [esp32-mdns.local]
   address = [fe80::xxxx:xxxx:xxxx:xxxx]
   port = [0]
   txt = []

[nopnop2002]

I use this.
https://components.espressif.com/components/espressif/mdns/versions/1.4.3

but don't work.

    // initialize mDNS
    ESP_ERROR_CHECK( mdns_init() );

    // set mDNS hostname
    ESP_ERROR_CHECK( mdns_hostname_set("esp32-server") );

    // set default mDNS instance name
    ESP_ERROR_CHECK( mdns_instance_name_set("ESP32 with mDNS") );

    // add service
    //ESP_ERROR_CHECK( mdns_service_add(NULL, "_device-info", "_tcp", 80, NULL, 0) );
    ESP_ERROR_CHECK( mdns_service_add(NULL, "_device-info", "_tcp", 0, NULL, 0) );

• My environment

$ cat idf_component.yml
## IDF Component Manager Manifest File
dependencies:
  espressif/mdns:
    version: "^1.4.3"
    rules:
      - if: "idf_version >=5.0"

$ head managed_components/espressif__mdns/CHANGELOG.md
# Changelog

## [1.4.3](https://github.com/espressif/esp-protocols/commits/mdns-v1.4.3)

### Features

- support zero item when update subtype ([5bd82c01](https://github.com/espressif/esp-protocols/commit/5bd82c01))

## [1.4.2](https://github.com/espressif/esp-protocols/commits/mdns-v1.4.2)


$ idf.py --version
ESP-IDF v5.4

• My logging:

ESP_ERROR_CHECK failed: esp_err_t 0x102 (ESP_ERR_INVALID_ARG) at 0x400d7911
--- 0x400d7911: initialize_mdns at /home/nop/rtos/mdns-service-add/main/main.c:69 (discriminator 1)

file: "./main/main.c" line 69
func: initialize_mdns
expression: mdns_service_add(NULL, "_device-info", "_tcp", 0, NULL, 0)

abort() was called at PC 0x40089597 on core 0
--- 0x40089597: _esp_error_check_failed at /home/nop/esp-idf/components/esp_system/esp_err.c:49



Backtrace: 0x40081a76:0x3ffbaad0 0x400895a1:0x3ffbaaf0 0x4009124d:0x3ffbab10 0x40089597:0x3ffbab80 0x400d7911:0x3ffbabb0 0x400d7b9e:0x3ffbabf0 0x40158707:0x3ffbac10 0x4008a0ed:0x3ffbac40
--- 0x40081a76: panic_abort at /home/nop/esp-idf/components/esp_system/panic.c:463
0x400895a1: esp_system_abort at /home/nop/esp-idf/components/esp_system/port/esp_system_chip.c:92
0x4009124d: abort at /home/nop/esp-idf/components/newlib/abort.c:38
0x40089597: _esp_error_check_failed at /home/nop/esp-idf/components/esp_system/esp_err.c:49
0x400d7911: initialize_mdns at /home/nop/rtos/mdns-service-add/main/main.c:69 (discriminator 1)
0x400d7b9e: app_main at /home/nop/rtos/mdns-service-add/main/main.c:180
0x40158707: main_task at /home/nop/esp-idf/components/freertos/app_startup.c:208
0x4008a0ed: vPortTaskWrapper at /home/nop/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:139

[david-cermak]

The fix hasn't been merged yet. It's not included in the v1.4.3 (pushed only a quick release the other day to publish that "zero item subtypes" fix)

This issue will be closed once the fix lands on master.

To test it locally you can:

1. Point to your local mdns component

#  idf_component.yml
dependencies:
  espressif/mdns:
+  override_path: /path/to/esp_protocol_repo/components/mdns

2. Fetch the referenced PR

$ cd /path/to/esp_protocol_repo/
$ git fetch origin pull/730/head && git checkout FETCH_HEAD

[nopnop2002]

@david-cermak

Thank you for your comment.

Once the fix is ​​in master, I will close this issue.

[david-cermak]

The fix's been merged and published in mdns v1.5

[nopnop2002]

We have confirmed that it works properly with mdns1.5.1.