Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(websocket): Added linux port for websocket (IDF-7097) #310

Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat(websocket): Added linux port for websocket (IDF-7097) #310

merged 1 commit into from
Jul 27, 2023

Conversation

gabsuren
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gabsuren gabsuren changed the title feat(websocket): Added linux port for websocket feat(websocket): Added linux port for websocket (IDF-7097) Jun 20, 2023
@gabsuren gabsuren force-pushed the feat/websocket_linux_port_component branch from b5c026a to 534ba08 Compare June 20, 2023 10:55
@gabsuren gabsuren force-pushed the feat/websocket_linux_port_component branch 17 times, most recently from 7cb54f1 to a4c5869 Compare June 26, 2023 16:40
@gabsuren gabsuren marked this pull request as ready for review June 26, 2023 16:43
david-cermak
david-cermak requested changes Jun 27, 2023
View reviewed changes
.github/workflows/publish-coverage-report.yml Outdated Show resolved Hide resolved
.github/workflows/publish-coverage-report.yml Outdated Show resolved Hide resolved
.github/workflows/websocket__build-host-tests.yml Outdated Show resolved Hide resolved
.github/workflows/websocket__build-target-test.yml Outdated Show resolved Hide resolved
components/esp_websocket_client/CMakeLists.txt Outdated Show resolved Hide resolved
components/esp_websocket_client/test/host_test/main/main.c Outdated Show resolved Hide resolved
components/esp_websocket_client/test/host_test/main/main.c Outdated Show resolved Hide resolved
components/esp_websocket_client/test/host_test/sdkconfig.defaults Outdated Show resolved Hide resolved
.github/workflows/websocket__build-host-tests.yml Outdated Show resolved Hide resolved
.github/workflows/websocket__build-host-tests.yml Outdated Show resolved Hide resolved
@gabsuren gabsuren force-pushed the feat/websocket_linux_port_component branch 7 times, most recently from 288a30e to eed36e3 Compare July 7, 2023 17:46
@gabsuren gabsuren force-pushed the feat/websocket_linux_port_component branch 8 times, most recently from 54ddad0 to c2e3a35 Compare July 12, 2023 11:52
@gabsuren gabsuren force-pushed the feat/websocket_linux_port_component branch 5 times, most recently from b5ed744 to 8f81643 Compare July 18, 2023 09:53
@gabsuren gabsuren force-pushed the feat/websocket_linux_port_component branch from 8f81643 to a22391a Compare July 18, 2023 10:18
@gabsuren gabsuren requested a review from david-cermak July 18, 2023 10:21
david-cermak
david-cermak reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about reusing the example

@gabsuren
Copy link
Contributor Author

gabsuren commented Jul 26, 2023 •
edited
Loading

@david-cermak thank you for the review.
As for the existing target example, it required the use of components esp_netif, esp_timer, esp_wifi, and json. For the esp_netif, we needed to utilize the existing solution from esp_modem. I decided to address this within the scope of another story [Update/support of linux port for all existing components to support common reusable actions, headers, workflows]-IDF-7856

@gabsuren gabsuren requested a review from david-cermak July 26, 2023 13:10
@gabsuren gabsuren merged commit 5143f5a into espressif:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-cermak david-cermak david-cermak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabsuren @CLAassistant @david-cermak @suren-gabrielyan-espressif