Fix MDNS free host list (IDFGH-11116) #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
espressif-bot
added
Status: Selected for Development
Status: Opened
and removed
Status: Opened
Status: Selected for Development
labels
|
@tannewt Thank you for your contribution. The modification seems good to me. |
gabsuren
requested review from
david-cermak and
gabsuren
and removed request for
david-cermak
gabsuren
suggested changes
Oct 2, 2023
There was a problem hiding this comment.
Thank you for your contribution. The modification seems good to me.
Please update the commit message to align it with our formatting rules, so it can pass the CI. As commit message must be scoped with fix(mdns):
It can be for example:
fix(mdns): free host list on destroy
gabsuren
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, any use of
_mdns_host_listrisks crashing due to use of freed memory.