Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(websocket): Added new API esp_websocket_client_append_header (IDF-7893) #371

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

gabsuren
Copy link
Contributor

@gabsuren gabsuren commented Oct 9, 2023

Added new API esp_websocket_client_append_header
Also updated host example, to enhance covertly analyzing

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2023

CLA assistant check
All committers have signed the CLA.

@gabsuren gabsuren changed the title feat(websocket): Added new API esp_websocket_client_append_header feat(websocket): Added new API esp_websocket_client_append_header (IDF-7893) Oct 9, 2023
@gabsuren gabsuren force-pushed the feat/ws_client_multiheader_api branch 4 times, most recently from cf209a7 to 4bcdf38 Compare October 9, 2023 10:38
@gabsuren gabsuren requested a review from david-cermak October 9, 2023 10:40
@gabsuren gabsuren force-pushed the feat/ws_client_multiheader_api branch from 4bcdf38 to faaa26b Compare October 9, 2023 10:48
@gabsuren gabsuren force-pushed the feat/ws_client_multiheader_api branch from faaa26b to a231cf9 Compare October 9, 2023 11:51
@gabsuren gabsuren requested a review from david-cermak October 9, 2023 11:51
@gabsuren gabsuren force-pushed the feat/ws_client_multiheader_api branch from a231cf9 to 0d77233 Compare October 9, 2023 14:05
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@gabsuren gabsuren force-pushed the feat/ws_client_multiheader_api branch from 0d77233 to 1ef9fb8 Compare October 10, 2023 08:44
@gabsuren gabsuren force-pushed the feat/ws_client_multiheader_api branch 9 times, most recently from 3e37746 to c4048c7 Compare October 10, 2023 15:46
@gabsuren gabsuren requested a review from david-cermak October 10, 2023 15:47
@gabsuren gabsuren force-pushed the feat/ws_client_multiheader_api branch from c4048c7 to 39e9725 Compare October 16, 2023 08:27
@gabsuren gabsuren merged commit 3e8de3a into espressif:master Oct 16, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants