-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(websocket): Added new API esp_websocket_client_append_header
(IDF-7893)
#371
Merged
gabsuren
merged 1 commit into
espressif:master
from
gabsuren:feat/ws_client_multiheader_api
Oct 16, 2023
Merged
feat(websocket): Added new API esp_websocket_client_append_header
(IDF-7893)
#371
gabsuren
merged 1 commit into
espressif:master
from
gabsuren:feat/ws_client_multiheader_api
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabsuren
changed the title
feat(websocket): Added new API
feat(websocket): Added new API Oct 9, 2023
esp_websocket_client_append_header
esp_websocket_client_append_header
(IDF-7893)
gabsuren
force-pushed
the
feat/ws_client_multiheader_api
branch
4 times, most recently
from
October 9, 2023 10:38
cf209a7
to
4bcdf38
Compare
gabsuren
force-pushed
the
feat/ws_client_multiheader_api
branch
from
October 9, 2023 10:48
4bcdf38
to
faaa26b
Compare
david-cermak
reviewed
Oct 9, 2023
gabsuren
force-pushed
the
feat/ws_client_multiheader_api
branch
from
October 9, 2023 11:51
faaa26b
to
a231cf9
Compare
gabsuren
force-pushed
the
feat/ws_client_multiheader_api
branch
from
October 9, 2023 14:05
a231cf9
to
0d77233
Compare
david-cermak
reviewed
Oct 9, 2023
david-cermak
reviewed
Oct 9, 2023
david-cermak
reviewed
Oct 9, 2023
david-cermak
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
gabsuren
force-pushed
the
feat/ws_client_multiheader_api
branch
from
October 10, 2023 08:44
0d77233
to
1ef9fb8
Compare
components/esp_websocket_client/examples/target/main/websocket_example.c
Outdated
Show resolved
Hide resolved
gabsuren
force-pushed
the
feat/ws_client_multiheader_api
branch
9 times, most recently
from
October 10, 2023 15:46
3e37746
to
c4048c7
Compare
gabsuren
force-pushed
the
feat/ws_client_multiheader_api
branch
from
October 16, 2023 08:27
c4048c7
to
39e9725
Compare
david-cermak
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new API esp_websocket_client_append_header
Also updated host example, to enhance covertly analyzing