fix : Return correct error code for esp_websocket_client_send_with_opcode (IDFGH-11291)

[sjames]

This function esp_websocket_client_send_with_opcode was incorrectly sending ESP_FAIL even on success. Fixing this.

Fixes issue: #392

[CLAassistant]

All committers have signed the CLA.

[david-cermak]

Thanks for the fix!

[gabsuren]

@sjames thank you for the contribution.
Nitpick, I would like to suggest rename of int error = ESP_OK to int ret = ESP_OK, as in a good case it is ESP_OK which is not error.
And also need to modify commit message to fix(websocket): Return error code correctly so it can pass pre-commit hook check

Thanks again

[gabsuren]

@sjames thank you for the update! The changes look good to me.
But as you see now there are two commits now

The CI will still fail if we merge it like that. You can merge those to commit to one, by

1. git rebase -i HEAD~2
2. replace pick with squash for the second commit
3. Edit the Commit Message:
4. Finalize the Rebase and push changes by --force (git push --f)

If you face any issues, I can cherry-pick your changes(keeping the history/metadata) and push it in separate PR.
Please let me know in case any help needed.

Thanks
Suren

[sjames]

@sjames thank you for the update! The changes look good to me. But as you see now there are two commits now

The CI will still fail if we merge it like that. You can merge those to commit to one, by

1. `git rebase -i HEAD~2`

2. replace pick with squash for the second commit

3. Edit the Commit Message:

4. Finalize the Rebase and push changes by --force  (`git push --f`)

If you face any issues, I can cherry-pick your changes(keeping the history/metadata) and push it in separate PR. Please let me know in case any help needed.

Thanks Suren

I think I followed the instructions and pushed the changes. If this still doesn't work, I would really appreciate your cherry-picking offer!

Thanks,
Sojan

[gabsuren]

Created #401 based on this PR