Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console_cmd_ifconfig: not supporting the ppp netif and will panic (IDFGH-11607) #449

Closed
3 tasks done
dapeng0512 opened this issue Dec 5, 2023 · 2 comments
Closed
3 tasks done
Assignees

Comments

@dapeng0512
Copy link

Answers checklist.

  • I have read the documentation for esp-protocols components and the issue is not addressed there.
  • I have updated my esp-protocols branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report

When i enable ppp with 4g module, run ifconfig will panic. I found panic's place.

version: 1.0.0

static void print_iface_details(esp_netif_t *esp_netif)
{
    ...

    struct netif *lwip_netif = esp_netif_get_netif_impl(esp_netif); // !!! return NULL

    ESP_LOGI(TAG, "Interface Number: %d", lwip_netif->num);  // PANIC at here

    ...

    ESP_LOGI(TAG, "Link Status: %s\n", netif_is_link_up(lwip_netif) ? "UP" : "DOWN"); // Here will also lead to panic

}

If it’s simply not going to let it panic, the ppp netif doesn’t support, that feels a big flaw!!!

@github-actions github-actions bot changed the title console_cmd_ifconfig: not supporting the ppp netif and will panic console_cmd_ifconfig: not supporting the ppp netif and will panic (IDFGH-11607) Dec 5, 2023
@espressif-abhikroy espressif-abhikroy self-assigned this Dec 6, 2023
@espressif-abhikroy
Copy link
Collaborator

@dapeng0512, thank you for bringing this issue to our attention. This component has not been tested on the PPP interface yet. I will address and fix it in the upcoming release soon.

@espressif-abhikroy
Copy link
Collaborator

@dapeng0512 This issue has been fixed in the V1.0.1 version of the console_cmd_ifconfig component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants