From 1fb02a9a6035d746f76769066f176aae0261bbfa Mon Sep 17 00:00:00 2001 From: Richard Allen Date: Fri, 8 Mar 2024 10:08:24 -0600 Subject: [PATCH] fix(websocket): fix esp_event dependency management Move esp_event from PRIV_REQUIRES to REQUIRES, as it is included by esp_websocket_client.h, so any code including that header also requires esp_event. This resolves the following build error for files not explicitly requiring esp_event: ninja: build stopped: subcommand failed. Compilation failed because esp_websocket_client.h (in "espressif__esp_websocket_client" component) includes esp_event.h, provided by esp_event component(s). However, esp_event component(s) is in the private requirements list of "espressif__esp_websocket_client". To fix this, move esp_event from PRIV_REQUIRES into REQUIRES list of idf_component_register call in ...\managed_components\espressif__esp_websocket_client\CMakeLists.txt. ninja failed with exit code 1, output of the command is in... --- components/esp_websocket_client/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/esp_websocket_client/CMakeLists.txt b/components/esp_websocket_client/CMakeLists.txt index 36b0766d4c..3e93b839a4 100644 --- a/components/esp_websocket_client/CMakeLists.txt +++ b/components/esp_websocket_client/CMakeLists.txt @@ -16,6 +16,6 @@ if(${IDF_TARGET} STREQUAL "linux") else() idf_component_register(SRCS "esp_websocket_client.c" INCLUDE_DIRS "include" - REQUIRES lwip esp-tls tcp_transport http_parser - PRIV_REQUIRES esp_timer esp_event) + REQUIRES lwip esp-tls tcp_transport http_parser esp_event + PRIV_REQUIRES esp_timer) endif()