We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The following config is deserialized as valid and should not. Discovered while testing #332
refresh_rate: 30 seconds appenders: stdout: kind: console requests: kind: file path: "log/requests.log" encoder: pattern: "{d} - {m}{n}" root: level: warn appenders: - stdout loggers: app::backend::db: level: info app::requests: level: info appenders: - requests additive: false
The text was updated successfully, but these errors were encountered:
The bug was that we just verified serde could parse the config, not that our tool liked the config. Suggesting the following patch to resolve:
serde
diff --git a/src/config/raw.rs b/src/config/raw.rs index 77963ed..171d1a1 100644 --- a/src/config/raw.rs +++ b/src/config/raw.rs @@ -525,6 +525,7 @@ loggers: let config_str = sample_file[config_start..config_end].trim(); let config = ::serde_yaml::from_str::<RawConfig>(config_str); - assert!(config.is_ok()) + assert!(config.is_ok()); + assert!(crate::init_raw_config(config.unwrap()).is_ok()); } }
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
The following config is deserialized as valid and should not. Discovered while testing #332
The text was updated successfully, but these errors were encountered: