Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thiserror dependency to version 2.0 #398

Open
StHagel opened this issue Nov 11, 2024 · 1 comment · May be fixed by #399
Open

Update thiserror dependency to version 2.0 #398

StHagel opened this issue Nov 11, 2024 · 1 comment · May be fixed by #399

Comments

@StHagel
Copy link

StHagel commented Nov 11, 2024

The thiserror crate recently upgraded to version 2.0. In my projects, log4rs is one of few crates, which still depend on thiserror version 1.0. Updating the requirement for thiserror in this crate would reduce the amount of dependencies needed.

I already tried just upgrading from 1.0.15 to 2.0 in Cargo.toml and the crate still compiled without problems and all tests passed.

@bconn98
Copy link
Collaborator

bconn98 commented Dec 31, 2024

Awesome! Appreciate you taking time to do this. I will put it in line behind our other collection of PRs. Hoping to get them rolling again soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants