Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICRS to Observed Coordinate Transformations #23

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

eta077
Copy link
Owner

@eta077 eta077 commented Nov 23, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 17, 2023

Test Results

38 tests  +2   38 ✔️ +2   0s ⏱️ ±0s
  4 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 5dd7264. ± Comparison against base commit 90172e1.

This pull request removes 24 and adds 26 tests. Note that renamed tests count towards both.
src/coordinates/lookup.rs - coordinates::lookup ‑ lookup_by_name (line 35)
src/fits/header.rs - fits::header ‑ FitsHeaderCard (line 286)
src/fits/header.rs - fits::header ‑ FitsHeaderKeyword (line 373)
src/fits/header.rs - fits::header::FitsHeader ‑ from_bytes (line 66)
src/fits/header.rs - fits::header::FitsHeader ‑ get_card (line 132)
src/fits/header.rs - fits::header::FitsHeader ‑ set_card (line 150)
src/fits/header.rs - fits::header::FitsHeader ‑ set_comment (line 258)
src/fits/header.rs - fits::header::FitsHeader ‑ set_value (line 203)
src/fits/header.rs - fits::header::FitsHeader ‑ to_bytes (line 108)
src/fits/header.rs - fits::header::FitsHeaderCard ‑ get_comment (line 336)
…
src/coordinates/frames.rs - coordinates::frames::Icrs ‑ to_alt_az (line 29)
src/coordinates/lookup.rs - coordinates::lookup ‑ lookup_by_name (line 43)
src/fits/header.rs - fits::header ‑ FitsHeaderCard (line 300)
src/fits/header.rs - fits::header ‑ FitsHeaderKeyword (line 393)
src/fits/header.rs - fits::header::FitsHeader ‑ from_bytes (line 68)
src/fits/header.rs - fits::header::FitsHeader ‑ get_card (line 138)
src/fits/header.rs - fits::header::FitsHeader ‑ set_card (line 158)
src/fits/header.rs - fits::header::FitsHeader ‑ set_comment (line 270)
src/fits/header.rs - fits::header::FitsHeader ‑ set_value (line 213)
src/fits/header.rs - fits::header::FitsHeader ‑ to_bytes (line 112)
…

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (f4aa375) 79.64% compared to head (7b94c13) 96.74%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #23       +/-   ##
===========================================
+ Coverage   79.64%   96.74%   +17.10%     
===========================================
  Files          10       58       +48     
  Lines        1670    12490    +10820     
===========================================
+ Hits         1330    12084    +10754     
- Misses        340      406       +66     
Files Coverage Δ
src/coordinates/erfa/ab.rs 100.00% <100.00%> (ø)
src/coordinates/erfa/apcs.rs 100.00% <100.00%> (ø)
src/coordinates/erfa/epv00.rs 100.00% <ø> (ø)
src/coordinates/erfa/fad03.rs 100.00% <100.00%> (ø)
src/coordinates/erfa/fae03.rs 100.00% <100.00%> (ø)
src/coordinates/erfa/faf03.rs 100.00% <100.00%> (ø)
src/coordinates/erfa/fal03.rs 100.00% <100.00%> (ø)
src/coordinates/erfa/falp03.rs 100.00% <100.00%> (ø)
src/coordinates/erfa/faom03.rs 100.00% <100.00%> (ø)
src/coordinates/erfa/fapa03.rs 100.00% <100.00%> (ø)
... and 40 more

@eta077 eta077 marked this pull request as ready for review March 21, 2023 18:01
Implement iers and erfa functionality
@eta077 eta077 force-pushed the coordinate-lookup-function branch from 27284ae to 32f3ffc Compare March 22, 2023 01:09
@eta077 eta077 added the blocked Waiting on external dependencies label Mar 26, 2023
@eta077
Copy link
Owner Author

eta077 commented Mar 26, 2023

Note: I consider this feature complete, but because of the amount of code duplicated from Astropy and ERFA, I have sent messages to their respective maintainers to ensure everything is above-board as far as licensing and attribution

@eta077 eta077 changed the title Coordinate lookup function ICRS to Observed Coordinate Transformations Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants