Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of robustness test adding key concepts used in the test #18708

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

serathius
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 47.72727% with 46 lines in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (f5acd17) to head (954d00c).
Report is 65 commits behind head on main.

Current head 954d00c differs from pull request most recent head bd0d1a6

Please upload reports for the commit bd0d1a6 to get more accurate results.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/global.go 0.00% 12 Missing ⚠️
etcdctl/ctlv3/command/make_mirror_command.go 0.00% 10 Missing ⚠️
etcdctl/ctlv3/command/ep_command.go 0.00% 6 Missing ⚠️
client/v3/mock/mockserver/mockserver.go 0.00% 4 Missing ⚠️
client/v3/config.go 87.50% 1 Missing and 1 partial ⚠️
client/v3/snapshot/v3_snapshot.go 0.00% 2 Missing ⚠️
etcdctl/ctlv3/ctl.go 0.00% 2 Missing ⚠️
pkg/netutil/netutil.go 50.00% 2 Missing ⚠️
client/v3/client.go 80.00% 0 Missing and 1 partial ⚠️
client/v3/experimental/recipes/key.go 50.00% 1 Missing ⚠️
... and 4 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
client/v3/lease.go 90.87% <100.00%> (ø)
client/v3/retry.go 79.48% <100.00%> (+0.17%) ⬆️
client/v3/retry_interceptor.go 65.61% <100.00%> (ø)
client/v3/watch.go 92.84% <100.00%> (-0.80%) ⬇️
etcdctl/ctlv3/command/printer_json.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/watch_command.go 44.08% <ø> (ø)
pkg/adt/interval_tree.go 88.72% <ø> (ø)
pkg/expect/expect.go 79.12% <100.00%> (ø)
pkg/featuregate/feature_gate.go 87.66% <100.00%> (ø)
pkg/flags/flag.go 68.57% <100.00%> (ø)
... and 24 more

... and 21 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18708   +/-   ##
=======================================
  Coverage   68.72%   68.73%           
=======================================
  Files         420      420           
  Lines       35494    35508   +14     
=======================================
+ Hits        24395    24405   +10     
- Misses       9665     9667    +2     
- Partials     1434     1436    +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5acd17...bd0d1a6. Read the comment docs.

@jmhbnz
Copy link
Member

jmhbnz commented Oct 10, 2024

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @serathius

tests/robustness/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@henrybear327 henrybear327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @serathius ! :)

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuweid, henrybear327, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 5bd72b7 into etcd-io:main Oct 23, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants