-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] add tls min/max version to grpc proxy #18829
Conversation
note to myself, I need to update the CHANGELOG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this PR resolve the workflow failure.
@ahrtr I have rebased, but I don't think this workflow failure is related to this PR nor main. |
new CVE? @ivanvc @jmhbnz @ArkaSaha30
|
Raised #18898 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @tjungblu
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Edit: ah, we need a rebase to have green tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport LGTM. Should we rebase this branch before merging (to have green CI status)? Or should we just merge?
@tjungblu would you mind rebasing this PR before we merge it? thx |
This adds the min and max TLS version support from etcd-io#13506 and etcd-io#15156 to the grpc proxy. Fixes etcd-io#13506 Signed-off-by: Thomas Jungblut <[email protected]>
done |
/retest |
This adds the min and max TLS version support from #13506 and #15156 to the grpc proxy.
Fixes #13506
Backport of #18816
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.